This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
Implements ajax load using HTM imports - DO NOT MERGE #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
| for (var i = 0; i < e.path.length; ++i) { | ||
| var el = e.path[i]; | ||
| if (el.localName == 'a') { | ||
| if (!el.getAttribute('href').match(/^(https?:|javascript:|\/\/)/) && |
There was a problem hiding this comment.
I think it would be better to require that the link in HTML opts out to be ajaxified in an explicit way, rather than by matching discreet criteria on href, origin and target. This avoids introducing in future links that should not be ajaxified but are by mistake. E.g. I wanted to explicitly add data-ajax-link attribute to links I intend to be ajaxified in HTML.
There was a problem hiding this comment.
+1. Ripped this straight from pp.org. Ajax should be handled with the URL changes (and you're still on the site). Everything should move off that.
ebidel
changed the title
|
Closing in favor of #94 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jeffposnick @devnook @brendankenny
Each page defines an HTML import file that contains
<templates>for parts of the page it wants to replace. That content is injected using a<template ref>. The benefit of this approach is that bindings in the injected content get picked up by the page's auto-binding template.The page can also define a bit of metadata for other parts of the page that need updating (example).
Essentially, we've just invented a web components-based client-side solution for templating :)
Looking for feedback on this idea. Please fetch this branch and give it a go.