A gulp task to generate a list of files to precache #56
Conversation
| @@ -48,6 +44,6 @@ if ('serviceWorker' in navigator) { | |||
| }; | |||
| }; | |||
| }, function(err) { | |||
| console.log(err); | |||
| console.error('Service worker registration failed:', err); | |||
There was a problem hiding this comment.
Add a TODO to log this to GA.
There was a problem hiding this comment.
In this particular case, I don't think we'll get anything useful via GA logging—the only reasons why the register() call should reject are due to us messing something up (either trying to serve the sw.js script from an untrusted location, or pushing out a sw.js with a syntax error). Hopefully neither of those things will actually happen in the actual production environment.
As part of a larger question, how would logging this sort of thing fit into our overall GA strategy? I.e. what sorts of things should we be keeping track of, other than page views and performance metrics?
There was a problem hiding this comment.
We setup a window.onerror handler for santa that reported any client-side errors in realtime to GA. That was fairly useful for catching bonehead mistakes we pushed. We can do the same for IOWA. It's pretty handy.
There was a problem hiding this comment.
Okay, I'll abstract out the GA error logging into a helper that could be called from either window.onerror or explicitly from within a Promise rejection handler. I don't believe there's any global way to call such a helper function whenever any Promise rejects (and that could get very noisy, if there was), so we'll have to remember to explicitly add in the logging helper in Promise rejections.
|
Reviewed. Can you also add a section to the README |
|
Thanks for the review. I've been thinking about this as a more general pattern to drive service worker adoption (and one that isn't specific to |
…lly, and is also called automatically via window.onerror.
|
So I've piled the GA error tracking into this PR, closing #77, and call the same error tracker helper manually if the service worker registration rejects. |
…a-gulp Conflicts: README.md gulpfile.js
|
LGTM. Needs a rebase. |
|
Having spent more time experimenting with https://github.com/jeffposnick/gulp-sw-precache, I think it's a better approach than what I initially implemented in this PR, and now I don't think it's worth merging this in. Sorry for the wasted review effort. Look for a fresh PR based on the code from https://github.com/jeffposnick/gulp-sw-precache |
@ebidel @devnook & co.:
As an alternative to hardcoding a list of URLs that should be cached during the service worker's
installevent, this code takes the more flexible approach of generating that list via agulptask, based on (a subset of) the actual files present on the server.There's no concept of a "config" file for
shed, so the code cobbles something together that gets loaded viaimportScriptswhen the service worker starts up. (Only the precache list is being generated right now, but in the future, ifshedsupports it, cache versioning could also be controlled via a similar approach and configured viagulp.)The list of resources to be precached is very broad right now, and there's a
TODOto investigate paring that down.To make local developer saner, no files are precached when running the
servetask, but you can override this behavior by manually runninggenerate-shed-config-devafterserve.