This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Fixed bug where FAB state was not correct #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changing to a downward binding shouldnt have an effect here. What's the bug? |
|
Sometimes when clicking on a session that's not bookmarked (the checkbox is not checked) the FAB was highlighted/active. This seems to remove this behavior. To replicate: 1 - Have at least 1 bookmarked session:
2 - Reload the page: http://localhost:3000/io2016/schedule#day1/ 3 - Click on an unbookmarked session: Looks OK:
4 - Click on a bookmarked session: Looks OK:
5 - Re-open an unbookmarked session. Looks bad:
|
|
Mhh never mind. I just re-tested and this PR does not fix the behavior ... The bug is still there though :D |
|
There are a couple of small bugs like this. I can take a look. Can you add this to the schedule bugs bug :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ebidel PTAL