Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve username behavior #17114

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

AnthonyZhang220
Copy link

@AnthonyZhang220 AnthonyZhang220 commented Oct 15, 2021

Fixes #17113

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
This reverts commit e824989.
Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
@google-cla
Copy link

google-cla bot commented Oct 15, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
@google-cla
Copy link

google-cla bot commented Oct 15, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
@github-actions
Copy link

Stale PRs will be automatically closed to keep this repo clean. If there is no activity on this PR in the next 7 days, this PR will be closed.

@github-actions github-actions bot added the Stale label Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change validation.py
1 participant