Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated validations.py python script. #9283

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hostankit
Copy link

@hostankit hostankit commented Nov 1, 2020

Fixed the behaviour of validate_user function in validations.py
Closes: #1

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

Updated validations.py python script.
Fixed the behaviour of validate_user function in validations.py
@google-cla
Copy link

google-cla bot commented Nov 1, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Copy link
Author

@hostankit hostankit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code successfully checks for two forbidden characters( _ . ) in given input. great : )

Copy link
Author

@hostankit hostankit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any response?

@hostankit
Copy link
Author

hostankit commented Nov 1, 2020 via email

@hostankit
Copy link
Author

@googlebot I signed it!

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot I signed it!

@hostankit
Copy link
Author

@googlebot I signed it!

Copy link
Author

@hostankit hostankit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@hostankit hostankit mentioned this pull request Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Course3/Lab4: Usernames should always start with letters
1 participant