Skip to content

Commit

Permalink
Migrate from deprecated boxed primitive constructors to their replace…
Browse files Browse the repository at this point in the history
…ments. E.g., `new Integer(...)` becomes `Integer.valueOf(...)`.

The boxed primitive constructors are deprecated **for removal**. That means these APIs _will be deleted_ in a future JDK release and this library _will stop compiling_!

NOTE: if piper is _not_ the source of truth for this 3p library, please work with upstream maintainers to land this change (it is your responsibility to do so --- see "Review & accept maintenance changes" @ go/thirdparty/responsibilities#owner).

More info: go/boxed-primitive-constructors-lsc b/321209431

Tested:
    TAP --sample ran all affected tests and none failed
    http://test/OCL:608804363:BASE:608763264:1708480783015:e2655798
PiperOrigin-RevId: 608820838
  • Loading branch information
kluever authored and Copybara-Service committed Feb 21, 2024
1 parent c20e781 commit cafcb24
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions protobuf/tests/CompatibilityTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -650,18 +650,18 @@ public void testSetAndGetFieldWithFieldDescriptor() throws Exception {
}

TypicalData.Builder dataBuilder = TypicalData.newBuilder();
dataBuilder.setField(fields[1], new Integer(42));
dataBuilder.setField(fields[1], Integer.valueOf(42));
dataBuilder.setField(fields[2], ByteString.copyFromUtf8("foo"));
dataBuilder.setField(fields[3], TypicalData.EnumType.VALUE9.getValueDescriptor());
dataBuilder.setField(fields[11], TypicalDataMessage.newBuilder().build());
dataBuilder.setField(fields[12], Boolean.TRUE);
dataBuilder.setField(fields[13], new Float(43.8));
dataBuilder.setField(fields[14], new Double(44.5));
dataBuilder.setField(fields[13], Float.valueOf((float) 43.8));
dataBuilder.setField(fields[14], Double.valueOf(44.5));
dataBuilder.setField(fields[15], "bar");
dataBuilder.setField(fields[16], new Integer(24));
dataBuilder.setField(fields[17], new Long(4422));
dataBuilder.setField(fields[18], new Long(2244));
dataBuilder.addRepeatedField(fields[4], new Integer(72));
dataBuilder.setField(fields[16], Integer.valueOf(24));
dataBuilder.setField(fields[17], Long.valueOf(4422));
dataBuilder.setField(fields[18], Long.valueOf(2244));
dataBuilder.addRepeatedField(fields[4], Integer.valueOf(72));
dataBuilder.addRepeatedField(fields[8], "aaa");
dataBuilder.addRepeatedField(fields[8], "bbb");
dataBuilder.setRepeatedField(fields[8], 1, "ccc");
Expand All @@ -679,8 +679,8 @@ private void checkGetters(TypicalDataOrBuilder data, FieldDescriptor[] fields) {
assertEquals("foo", new String(data.getMyBytes().toByteArray()));
assertEquals(TypicalData.EnumType.VALUE9, data.getMyEnumType());
assertTrue(data.getMyBool());
assertEquals(new Float(43.8), data.getMyFloat());
assertEquals(new Double(44.5), data.getMyDouble());
assertEquals(Float.valueOf((float) 43.8), data.getMyFloat());
assertEquals(Double.valueOf(44.5), data.getMyDouble());
assertEquals("bar", data.getMyString());
assertEquals(24, data.getMyUint());
assertEquals(4422, data.getMyLong());
Expand Down

0 comments on commit cafcb24

Please sign in to comment.