error: failed batch processing sources: Should produce more helpful error messages #598

confile · 2015-09-01T07:51:04Z

While translating the following:

 /Applications/J2Objc/j2objc-0.9.8b/j2objc -d /Users/mg/Downloads/Majestella/shared/build/j2objcSrcGen -sourcepath /Users/mg/Downloads/Majestella/shared/src/main/java:/Users/mg/Downloads/Majestella/shared/build/translationExtraction:/Users/mg/Downloads/Majestella/shared/build/source/apt:/Users/mg/Downloads/Majestella/shared/build/source/base:/Users/mg/Downloads/Majestella/shared/src/test/java -classpath /Users/mg/Downloads/Majestella/shared/lib/json-20140107.jar:/Users/mg/Downloads/Majestella/shared/lib/javax.inject-1.jar:/Users/mg/Downloads/Majestella/shared/lib/auto-factory-1.0-beta2.jar:/Users/mg/Downloads/Majestella/shared/lib/auto-service-1.0-rc2.jar:/Users/mg/Downloads/Majestella/shared/lib/javawriter-2.5.1.jar:/Users/mg/Downloads/Majestella/shared-prebuild/build/libs/shared-prebuild-1.0.jar:/Applications/J2Objc/j2objc-0.9.8b/lib/j2objc_annotations.jar:/Applications/J2Objc/j2objc-0.9.8b/lib/j2objc_guava.jar:/Applications/J2Objc/j2objc-0.9.8b/lib/j2objc_junit.jar:/Applications/J2Objc/j2objc-0.9.8b/lib/jre_emul.jar:/Applications/J2Objc/j2objc-0.9.8b/lib/javax.inject-1.jar:/Applications/J2Objc/j2objc-0.9.8b/lib/jsr305-3.0.0.jar:/Applications/J2Objc/j2objc-0.9.8b/lib/mockito-core-1.9.5.jar:/Users/mg/Downloads/Majestella/shared/build/classes --no-package-directories --prefixes prefixes.properties -use-arc --doc-comments --generate-deprecated /Users/mg/Downloads/Majestella/shared/build/source/apt/generated/BPlaceTokenRegistryImpl.java /Users/mg/Downloads/Majestella/shared/build/source/apt/generated/ProxyModule.java /Users/mg/Downloads/Majestella/shared/build/source/apt/majestella/core/app/serviceSelection/ServiceSelectionPresenterMyProxyImpl.java /Users/mg/Downloads/Majestella/shared/src/main/java/TestClass.java

I get the following error:

  Working Dir:
  /Users/mg/Downloads/Majestella/shared
  Cause:
  org.gradle.process.internal.ExecException: Process 'command '/Applications/J2Objc/j2objc-0.9.8b/j2objc'' finished with non-zero exit value 1
  Standard Output:

  Error Output:
  1. ERROR: failed
  2. ERROR: failed
  3. ERROR: failed
  4. ERROR: failed
  5. ERROR: failed
  6. ERROR: failed
  7. ERROR: failed
  8. ERROR: failed
  9. ERROR: failed
  10. ERROR: failed
  11. ERROR: failed
  12. ERROR: failed
  12 problems (12 errors)
  error: failed batch processing sources

The text was updated successfully, but these errors were encountered:

confile · 2015-09-01T07:51:32Z

With version 0.9.7 I did not have this problem.

kstanger · 2015-09-01T13:52:53Z

Could this be an error from Gradle, not J2ObjC?

On Tue, 1 Sep 2015 at 03:51 Michael Gorski notifications@github.com wrote:

With version 0.9.7 I did not have this problem.

—
Reply to this email directly or view it on GitHub
#598 (comment).

tomball · 2015-09-01T14:32:59Z

Why is the command broken up in two lines? I doubt you have a directory
"/App\n lications". Is that a cut&paste issue, or Gradle one building its
sub-command string?

On Tue, Sep 1, 2015 at 6:53 AM Keith Stanger notifications@github.com
wrote:

Could this be an error from Gradle, not J2ObjC?

On Tue, 1 Sep 2015 at 03:51 Michael Gorski notifications@github.com
wrote:

With version 0.9.7 I did not have this problem.

—
Reply to this email directly or view it on GitHub
#598 (comment).

—
Reply to this email directly or view it on GitHub
#598 (comment).

brunobowden · 2015-09-02T05:10:13Z

@mthvedt - I'm adding you as you authored the annotation error: "failed batch processing sources". What's of note in this case is that the error feedback is very limited as you'll see above. The annotation code may well be legitimately throwing an error but it could be much better feedback.

confile · 2015-09-02T07:51:39Z

@kstanger @tomball it seems to be a plugin issue so we will track it here: j2objc-contrib/j2objc-gradle#447

confile · 2015-09-02T16:49:18Z

After discussion with @brunobowden I decided to reopen.

brunobowden · 2015-09-02T16:52:04Z

Currently this appears to be an issue with the plugin. I suggested leaving this open as a request to improve how helpful the error messages were. The current STDERR was very obscure:

  Error Output:
  1. ERROR: failed
  2. ERROR: failed
  3. ERROR: failed
  4. ERROR: failed
  5. ERROR: failed
  6. ERROR: failed
  7. ERROR: failed
  8. ERROR: failed
  9. ERROR: failed
  10. ERROR: failed
  11. ERROR: failed
  12. ERROR: failed
  12 problems (12 errors)
  error: failed batch processing sources

confile · 2015-09-02T16:55:03Z

If it helps this was introduced in j2objc version 0.9.8 in version 0.9.7 I did not have this problem and error log.

confile · 2015-09-08T15:59:45Z

@kstanger @tomball This might be related to some Annotation Processor handling in j2objc version 0.9.8.

tomball · 2015-09-08T16:15:58Z

Anyone have an example of a failing annotation processor? The original
example can't be used, unless it's part of a public build. The translator
is just relying what the JDT annotation processor is writing to System.err,
so some debugging is necessary.

On Tue, Sep 8, 2015 at 8:59 AM Michael Gorski notifications@github.com
wrote:

@kstanger https://github.com/kstanger @tomball
https://github.com/tomball This might be related to some Annotation
Processor handling in j2objc version 0.9.8.

—
Reply to this email directly or view it on GitHub
#598 (comment).

brunobowden · 2015-09-08T16:24:35Z

@confile - I believe you have a public example you can now point to?

I'm on vacation right now but will look in to this further when I return
Sept 21.

On Tue, Sep 8, 2015, 9:16 AM Tom Ball notifications@github.com wrote:

Anyone have an example of a failing annotation processor? The original
example can't be used, unless it's part of a public build. The translator
is just relying what the JDT annotation processor is writing to System.err,
so some debugging is necessary.

On Tue, Sep 8, 2015 at 8:59 AM Michael Gorski notifications@github.com
wrote:

@kstanger https://github.com/kstanger @tomball
https://github.com/tomball This might be related to some Annotation
Processor handling in j2objc version 0.9.8.

—
Reply to this email directly or view it on GitHub
#598 (comment).

—
Reply to this email directly or view it on GitHub
#598 (comment).

confile · 2015-09-08T17:07:45Z

@tomball

I created a test project here: https://github.com/confile/j2objc-test

To reproduce the error just do:

gradle shared:clean gradle shared:j2objcTranslate
Change something.
gradle shared:j2objcTranslate

Note: If you change variables sometimes recompile works for whatever reason. Then just do some more changes.

tomball · 2015-09-08T20:12:23Z

Don't see a problem from the translator. I couldn't build the j2objc-test (too many dependencies), and so hacked the auto/service annotation processor to print messages to System.out and System.err, then throw an AssertionError. This printed out the stdout and stderr text, and for the processing error message, included the location and exception stack trace.

Since Michael is writing an annotation processor and having trouble with it, my guess is that "failed" was an earlier error message from his processor. If that's the case, switching to exceptions during development should provide better diagnostic information, such as shown below:

$ j2objc -classpath ~/jars/guava-18.0.jar:service.jar:common.jar -d . foo/bar/MyProcessor.java 
System.out: hello
System.err: goodbye
----------
1. ERROR in /Users/tball/tmp/foo/bar/MyProcessor.java (at line 0)
    package foo.bar;
    ^
Internal compiler error: java.lang.AssertionError: test failure at com.google.auto.service.processor.AutoServiceProcessor.process(AutoServiceProcessor.java:103)
----------
Exception in thread "main" java.lang.AssertionError: test failure
    at com.google.auto.service.processor.AutoServiceProcessor.process(AutoServiceProcessor.java:103)
    at j2objc.org.eclipse.jdt.internal.compiler.apt.dispatch.RoundDispatcher.handleProcessor(RoundDispatcher.java:139)
    at j2objc.org.eclipse.jdt.internal.compiler.apt.dispatch.RoundDispatcher.round(RoundDispatcher.java:121)
    at j2objc.org.eclipse.jdt.internal.compiler.apt.dispatch.BaseAnnotationProcessorManager.processAnnotations(BaseAnnotationProcessorManager.java:159)
    at j2objc.org.eclipse.jdt.internal.compiler.Compiler.processAnnotations(Compiler.java:818)
    at j2objc.org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:434)
    at j2objc.org.eclipse.jdt.internal.compiler.batch.Main.performCompilation(Main.java:4129)
    at j2objc.org.eclipse.jdt.internal.compiler.batch.Main.compile(Main.java:1694)
    at com.google.devtools.j2objc.pipeline.AnnotationPreProcessor.process(AnnotationPreProcessor.java:100)
    at com.google.devtools.j2objc.J2ObjC.run(J2ObjC.java:115)
    at com.google.devtools.j2objc.J2ObjC.main(J2ObjC.java:173)

confile · 2015-09-09T10:39:24Z

@tomball What do you mean by this?

switching to exceptions during development should provide better diagnostic information, such as shown below

As I said before it worked fine with j2objc 0.9.7 also incremental translation worked. But starting with 0.9.8 translation worked but incremental translation gave this strange error.

confile · 2015-09-11T12:15:17Z

@tomball Why do you close this issue the error is still there?

confile · 2015-09-17T08:18:20Z

@brunobowden I could modify the j2objc-gradle plugin to throw an error but where should I do that?

brunobowden · 2015-09-17T08:19:45Z

I believe this is an error in your annotation processor, your code.

On Thu, Sep 17, 2015, 9:18 AM Michael Gorski notifications@github.com
wrote:

@brunobowden https://github.com/brunobowden I could modify the
j2objc-gradle plugin to throw an error but where should I do that?

—
Reply to this email directly or view it on GitHub
#598 (comment).

confile · 2015-09-17T11:32:48Z

@brunobowden How could this be. The processor worked perfect with j2objc 0.9.7. It builds perfect when using the java plugins build task. It also build with j2objc 0.9.8 if you build after clean.

The problem occurs only when doing incremental compile. Changing parts which are not affect the annotation processor should not be affected by the annotation processor.

confile · 2015-09-17T11:33:09Z

@brunobowden So I guess it is an issue in j2objc 0.9.8

brunobowden mentioned this issue Sep 2, 2015

Incremental Compile fails with error: failed batch processing sources j2objc-contrib/j2objc-gradle#447

Closed

confile closed this as completed Sep 2, 2015

confile reopened this Sep 2, 2015

confile changed the title ~~error: failed batch processing sources~~ error: failed batch processing sources: Should produce more helpful error messages Sep 2, 2015

tomball closed this as completed Sep 8, 2015

tomball added the cannot reproduce label Sep 8, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

error: failed batch processing sources: Should produce more helpful error messages #598

error: failed batch processing sources: Should produce more helpful error messages #598

confile commented Sep 1, 2015

confile commented Sep 1, 2015

kstanger commented Sep 1, 2015

tomball commented Sep 1, 2015

brunobowden commented Sep 2, 2015

confile commented Sep 2, 2015

confile commented Sep 2, 2015

brunobowden commented Sep 2, 2015

confile commented Sep 2, 2015

confile commented Sep 8, 2015

tomball commented Sep 8, 2015

brunobowden commented Sep 8, 2015

confile commented Sep 8, 2015

tomball commented Sep 8, 2015

confile commented Sep 9, 2015

confile commented Sep 11, 2015

confile commented Sep 17, 2015

brunobowden commented Sep 17, 2015

confile commented Sep 17, 2015

confile commented Sep 17, 2015

error: failed batch processing sources: Should produce more helpful error messages #598

error: failed batch processing sources: Should produce more helpful error messages #598

Comments

confile commented Sep 1, 2015

confile commented Sep 1, 2015

kstanger commented Sep 1, 2015

tomball commented Sep 1, 2015

brunobowden commented Sep 2, 2015

confile commented Sep 2, 2015

confile commented Sep 2, 2015

brunobowden commented Sep 2, 2015

confile commented Sep 2, 2015

confile commented Sep 8, 2015

tomball commented Sep 8, 2015

brunobowden commented Sep 8, 2015

confile commented Sep 8, 2015

tomball commented Sep 8, 2015

confile commented Sep 9, 2015

confile commented Sep 11, 2015

confile commented Sep 17, 2015

brunobowden commented Sep 17, 2015

confile commented Sep 17, 2015

confile commented Sep 17, 2015