-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type hint at
property in basearray.pyi
#14909
Comments
Thanks for raising this! I think I left this out because circular imports make it tricky, but we should be able to figure it out. The name we use now is "index update helper", but that's a bit of a mouthful. If you search for "jnp.ndarray.at" you find this page: https://jax.readthedocs.io/en/latest/_autosummary/jax.numpy.ndarray.at.html We'd be open to suggestions for making that more discoverable. |
I don't think it's a bad name. As for discoverability, I'd suggest inserting the exact phrase in ndarray.at document, Array class, jax.ops document, and maybe also in the shape bits. Something like
in CS paper title fashion. I was trying to sell the array-api people this api, now I can tell them the name of the product. |
Unfortunately, the header on the |
Yes, this is what I meant. |
Type hint
jax.Array.at
to aid IDEs.Didn't submit a PR directly because
_IndexUpdateHelper
is in internal, do we change the name or__name__
to make it look better?General question for JAX developers: is there a 'canonical' name for the
at
-properties?jax.Array.at
is not convenient for verbal communication. Maybe, functional array index accessor? I really want a name that is searchable, and I could refer to, say when answering questions in Github discussions.The text was updated successfully, but these errors were encountered: