Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Reflect changes from numpy namespace refactor Part 4 #17244

Closed
mtsokol opened this issue Aug 23, 2023 · 1 comment · Fixed by #17277
Closed

ENH: Reflect changes from numpy namespace refactor Part 4 #17244

mtsokol opened this issue Aug 23, 2023 · 1 comment · Fixed by #17277
Assignees
@hawkinsp
Labels
enhancement New feature or request

Comments

@mtsokol
Copy link
Contributor

mtsokol commented Aug 23, 2023 •
edited

Hi!
There are new changes coming to NumPy's top namespace in numpy/numpy#24445:

  • row_stack (an alias for vstack) is being removed - I see that it's already deprecated in jax
  • Deprecated trapz and deprecated in1d - Would you like to also deprecate these functions in jax?
@mtsokol mtsokol added the enhancement New feature or request label Aug 23, 2023
@hawkinsp
Copy link
Member

We'll follow upstream NumPy on both. For trapz, we'd probably better also add jax.scipy.integrate.trapezoid so the new name is available.

hawkinsp added a commit to hawkinsp/jax that referenced this issue Aug 23, 2023
@hawkinsp
Deprecate jax.numpy.in1d.
1e258cf 
Issue google#17244
@hawkinsp hawkinsp mentioned this issue Aug 23, 2023
Merged
hawkinsp added a commit to hawkinsp/jax that referenced this issue Aug 23, 2023
@hawkinsp
Deprecate jax.numpy.in1d.
7c87191 
Issue google#17244
@hawkinsp hawkinsp self-assigned this Aug 24, 2023
hawkinsp added a commit to hawkinsp/jax that referenced this issue Aug 24, 2023
@hawkinsp
Deprecate jax.numpy.trapz.
2017d55 
Expose the current implementation of jax.numpy.trapz as jax.scipy.integrate.trapezoid instead.

Fixes google#17244
@hawkinsp hawkinsp mentioned this issue Aug 24, 2023
Merged
hawkinsp added a commit to hawkinsp/jax that referenced this issue Aug 24, 2023
@hawkinsp
Deprecate jax.numpy.trapz.
48e06df 
Expose the current implementation of jax.numpy.trapz as jax.scipy.integrate.trapezoid instead.

Fixes google#17244
jon-chuang pushed a commit to jon-chuang/jax that referenced this issue Aug 30, 2023
@hawkinsp @jon-chuang
Deprecate jax.numpy.trapz.
54ba273 
Expose the current implementation of jax.numpy.trapz as jax.scipy.integrate.trapezoid instead.

Fixes google#17244
@nsteinle nsteinle mentioned this issue Mar 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hawkinsp hawkinsp

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate jax.numpy.trapz. hawkinsp/jax
2 participants
@hawkinsp @mtsokol