-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AOT path doesn't typecheck DCE'd arguments #18686
Comments
Shardings are also not checked on DCE's operands. If we ever exposed shardings from tracers, we could exhibit a similar issue with mismatched shardings in place of shapes (avals) above. Ahead of that, we might still want to cautiously error because, on the JIT path, different shardings result in re-compilation, and part of the purpose of the AOT API is to guard against re-compilation. In other words, we could adapt an example like the one above that triggers a side effect (such as a |
Finally, the same goes for layouts once we've made them available. |
This keeps the promise of AOT that recompilation is guaranteed. Fixes #18686 PiperOrigin-RevId: 585788972
This keeps the promise of AOT that recompilation is guaranteed. Fixes #18686 PiperOrigin-RevId: 585788972
This keeps the promise of AOT that recompilation is guaranteed. Fixes #18686 PiperOrigin-RevId: 585788972
This keeps the promise of AOT that recompilation is guaranteed. Fixes #18686 PiperOrigin-RevId: 585788972
This keeps the promise of AOT that recompilation is guaranteed. Fixes #18686 PiperOrigin-RevId: 585788972
This keeps the promise of AOT that recompilation is guaranteed. Fixes #18686 PiperOrigin-RevId: 585788972
This keeps the promise of AOT that recompilation is guaranteed. Fixes #18686 PiperOrigin-RevId: 585788972
This keeps the promise of AOT that recompilation is guaranteed. Fixes #18686 PiperOrigin-RevId: 585788972
This keeps the promise of AOT that recompilation is guaranteed. Fixes #18686 PiperOrigin-RevId: 585788972
This keeps the promise of AOT that recompilation is guaranteed. Fixes #18686 PiperOrigin-RevId: 585788972
This keeps the promise of AOT that recompilation is guaranteed. Fixes #18686 PiperOrigin-RevId: 585788972
This keeps the promise of AOT that recompilation is guaranteed. Fixes #18686 PiperOrigin-RevId: 585788972
The second call to
g
should raise an error.The text was updated successfully, but these errors were encountered: