[sparse] bcoo_broadcast_in_dim: default to adding leading batch dimensions #10454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froystig
approved these changes
Apr 26, 2022
jakevdp
force-pushed
the
bcoo-broadcast-in-dim
branch
from
b0ac06d
to
79e0e76
Compare
jakevdp
force-pushed
the
bcoo-broadcast-in-dim
branch
from
79e0e76
to
0175479
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? Because in this situation batch dimensions always yield a more compact representation, and converting from batch to sparse dimensions is far cheaper than converting from sparse to batch dimensions.
This, along with a sparse lowering rule for
lax.concatenate_p, will allow us to support clean concatenation & stacking of sparse arrays.I'm a bit concerned that this might break an existing use-case, so I need to run some extra tests before merging.