normalize/rearrange (kw)args by signature in jit #10724
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normalize positional arguments and keyword arguments according to function signature. Thus the static arguments behavior will not depend on the way arguments passed.
YouJiacheng
force-pushed
the
normalize-args-kwargs-jit
branch
from
be9f266
to
cf97ecd
Compare
|
I have a different approach that I would prefer over this in my WIP on argument annotation. I will release this soon, but IMO it would be best to avoid changing the jit transformation behaviour without first completing the discussion in #10614 |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalize/Rearrange positional arguments and keyword arguments according to function signature.
Thus the static arguments and donate arguments behavior will not depend on the way arguments passed.
This is a breaking change, deprecation cycle might be needed.
Cache behavior is changed as well, cause
test_jit_kwargsfailure.Since the type of argument is determined by signature,
test_jit_with_mismatched_static_argnamesfail and need some modifications.