-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate initializers and activation functions to jax.nn #1262
Conversation
888c745
to
d9653c9
Compare
d9653c9
to
cc49d8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! My main request is not to put code in __init__.py
files and not to do from blah import *
. A few other minor suggestions too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great idea to make this change. It's a big improvement and emblematic of a good way to think about jax-core's tools-for-nn-library-builders going forward.
This PR does a few things:
jax.nn
namespace to centralize/official-ize the location of shared neural net-related functions.log_softmax
implementation to fix a numerical issue seen internally.jax.nn
, hopefully without breaking users.jax.nn
.Closes #1194 and #1195, re-closes #985.