Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multivariate normal support #1389

Closed
wants to merge 1 commit into from

Conversation

aeftimia
Copy link
Contributor

Simple implementation of multivariate normal distribution.

multivariate_normal(key, cov, mean*args) = normal(key, *args) * cov + mean

I tried to adhere to current conventions.

#1384

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@aeftimia
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@mattjj
Copy link
Member

mattjj commented Sep 27, 2019

Thanks for working on this!

However, this isn't implementing a multivariate Gaussian: in particular, we need to take a covariance matrix as an argument and compute a matrix square root. (Even in the scalar case, you'd need to multiply by the square root of the variance (cov in this PR), not multiply by the variance.)

I left some thoughts in a comment on #1384. If you're interested in following up, can you use those as a starting point? There's also a lot of info on this online, including on Wikipedia and in other numerical libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants