Make the default implementation of Log/Log2/Ln/Log1p in XLA accurate on all platforms, and tighten test tolerances accordingly. The new implementation is accurate to 2 ULP. #14142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
bot
force-pushed
the
test_504022808
branch
5 times, most recently
from
d75ac88
to
22764d3
Compare
copybara-service
bot
force-pushed
the
test_504022808
branch
2 times, most recently
from
641fc7e
to
a7589ba
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_504022808
branch
5 times, most recently
from
60f2345
to
54b53dd
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_504022808
branch
from
54b53dd
to
1130947
Compare
copybara-service
bot
force-pushed
the
test_504022808
branch
from
1130947
to
18be2a3
Compare
copybara-service
bot
force-pushed
the
test_504022808
branch
2 times, most recently
from
de41d0c
to
5fde197
Compare
…on all platforms, and tighten test tolerances accordingly. The new implementation is accurate to 2 ULP. This change also adds tests for +/-0, +/-inf, and NaN. PiperOrigin-RevId: 504022808
copybara-service
bot
force-pushed
the
test_504022808
branch
from
5fde197
to
54e6b1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the default implementation of Log/Log2/Ln/Log1p in XLA accurate on all platforms, and tighten test tolerances accordingly. The new implementation is accurate to 2 ULP.
This change also adds tests for +/-0, +/-inf, and NaN.