Deprecate jax.tree_map in favor of jax.tree.map #19930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why are we deprecating it? I thought the plan was too support both? |
Nope, the plan is to just have |
The plan is to support both |
jakevdp
force-pushed
the
dep-tree_map
branch
from
728c1af
to
e59a050
Compare
copybara-service bot
pushed a commit
to google/CommonLoopUtils
that referenced
this pull request
Apr 4, 2024
…https://jax.readthedocs.io/en/latest/changelog.html#jax-0-4-26-april-3-2024), `jax.tree_map` is deprecated. We should switch to `jax.tree.map` if/when the JAX minimum version is >=0.4.26. Additional context: * JAX PR that added the `jax.tree` module: google/jax#19588 * JAX PR that deprecated `jax.tree_map`: google/jax#19930 PiperOrigin-RevId: 621905494
copybara-service bot
pushed a commit
to google/CommonLoopUtils
that referenced
this pull request
Apr 4, 2024
…https://jax.readthedocs.io/en/latest/changelog.html#jax-0-4-26-april-3-2024), `jax.tree_map` is deprecated. We should switch to `jax.tree.map` if/when the JAX minimum version is >=0.4.26 for CLU. Additional context: * JAX PR that added the `jax.tree` module: google/jax#19588 * JAX PR that deprecated `jax.tree_map`: google/jax#19930 PiperOrigin-RevId: 621905494
copybara-service bot
pushed a commit
to google/CommonLoopUtils
that referenced
this pull request
Apr 5, 2024
…https://jax.readthedocs.io/en/latest/changelog.html#jax-0-4-26-april-3-2024), `jax.tree_map` is deprecated. We should switch to `jax.tree.map` if/when the JAX minimum version is >=0.4.26 for CLU. Additional context: * JAX PR that added the `jax.tree` module: google/jax#19588 * JAX PR that deprecated `jax.tree_map`: google/jax#19930 PiperOrigin-RevId: 621905494
copybara-service bot
pushed a commit
to google/CommonLoopUtils
that referenced
this pull request
Apr 5, 2024
…https://jax.readthedocs.io/en/latest/changelog.html#jax-0-4-26-april-3-2024), `jax.tree_map` is deprecated. We should switch to `jax.tree.map` if/when the JAX minimum version is >=0.4.26 for CLU. Additional context: * JAX PR that added the `jax.tree` module: google/jax#19588 * JAX PR that deprecated `jax.tree_map`: google/jax#19930 PiperOrigin-RevId: 622092167
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.