Add a fast path MPMD device_put test. #19954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_609749731
branch
3 times, most recently
from
333ff03
to
dc56640
Compare
This checks that if the devices in a sharding are different, we still take `xc.copy_array_to_devices_with_sharding` path. This is to prevent changes to shard_arg handler of Array that checks for devices instead of indices. PiperOrigin-RevId: 609760758
copybara-service
bot
force-pushed
the
test_609749731
branch
from
dc56640
to
4e61c88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a fast path MPMD device_put test.
This checks that if the devices in a sharding are different, we still take
xc.copy_array_to_devices_with_shardingpath.This is to prevent changes to shard_arg handler of Array that checks for devices instead of indices.