Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where axis size selected incorrectly in pure_callback vmap rule #19986

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Fix bug where axis size selected incorrectly in pure_callback vmap rule #19986

merged 1 commit into from
Feb 27, 2024

Conversation

sharadmv
Copy link
Member

Fixes #19978

@sharadmv sharadmv requested a review from mattjj February 26, 2024 23:13
mattjj
mattjj approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@mattjj mattjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels Feb 27, 2024
@copybara-service copybara-service bot merged commit fab8f6c into google:main Feb 27, 2024
11 of 13 checks passed
@sharadmv sharadmv deleted the pure-callback-bug branch February 27, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjj mattjj mattjj approved these changes

Assignees
No one assigned
Labels
pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jax.vmap(jax.pure_callback(...), in_axes=1) is broken
3 participants
@sharadmv @mattjj @kokoro-team