Refactor array_api namespace, relying more directly on jax.numpy
#21013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Micky774
changed the title
array_api namespace, relying more directly on jax.numpy
Micky774
force-pushed
the
array-api-trim
branch
2 times, most recently
from
4642197
to
36e53d9
Compare
jakevdp
reviewed
Apr 30, 2024
Micky774
force-pushed
the
array-api-trim
branch
2 times, most recently
from
a146278
to
9e85f58
Compare
Micky774
force-pushed
the
array-api-trim
branch
2 times, most recently
from
5c0b3de
to
f9dbcac
Compare
jakevdp
reviewed
Apr 30, 2024
jakevdp
requested changes
May 1, 2024
Micky774
force-pushed
the
array-api-trim
branch
2 times, most recently
from
0897b7f
to
c4cfbcb
Compare
jakevdp
requested changes
May 1, 2024
|
The current failure is due to needing to add some signature test skips for |
jakevdp
approved these changes
May 2, 2024
google-ml-butler
bot
added
kokoro:force-run
pull ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
jax.experimental.array_apinamespace by removing unnecessary wrappers around already-compliant functions in thejax.numpynamespace, and structuring thearray_apinamespace to pull directly fromjax.numpywhenever possible. After this PR, thearray_apisubmodule contain only:jax.numpyfrom breaking changes, which will be removed when the correspondingjax.numpybehavior is deprecated and made array API compliantjax.numpyand needs inclusion (e.g. introducingjax.numpy.matmul, which already exists injax.numpy.linalg).This PR also adds several
TODOitems describing what is required to cull that portion of thearray_apisubmodule, with the understanding that once it is empty,jax.numpywill be fully compliant. I figured it would be a bit neater to keep theTODOnotes dense in this submodule, rather than spreading them across thejax.numpysubmodule on their corresponding functions. It's also consistent with theTODOs for new functionality or namespace elements.This PR also modifies
jax.numpy.isdtypeto accept_ScalarMetaand other dtype-interpretable inputs.Note that the
array-api-testsissues manyUserWarningsfor the special cases test, as well as for their reporting utilities due to not understanding what@jitwrapped functions are in JAX, so this PR suppresses them in thejax-array-apiworkflow.This PR has been validated against the
array-api-testssuite for version2023.12, usingjax/experimental/array_api/skips.txt-- although it is worth noting that the test suite does not cover everything, e.g. is still missing support forcopyanddevicekeyword tests.cc: @jakevdp