Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Distributed data loading in a multi-host/multi-process environment doc #21181

Merged

Conversation

8bitmp3
Copy link
Contributor

@8bitmp3 8bitmp3 commented May 10, 2024

@jakevdp jakevdp self-assigned this May 10, 2024
@jakevdp
Copy link
Collaborator

jakevdp commented May 10, 2024

Is this notebook meant to be executable in a single-CPU context? If not please add it to nb_execution_excludepatterns in docs/conf.py, then the readthedocs build will pass.

@8bitmp3 8bitmp3 force-pushed the add-distributed-data-loading-doc branch from 8d80246 to 585378e Compare May 15, 2024 21:18
docs/conf.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! A few suggestions below

docs/distributed_data_loading.md Outdated Show resolved Hide resolved
docs/distributed_data_loading.md Outdated Show resolved Hide resolved
docs/distributed_data_loading.md Outdated Show resolved Hide resolved
docs/distributed_data_loading.md Outdated Show resolved Hide resolved
docs/distributed_data_loading.md Outdated Show resolved Hide resolved
docs/distributed_data_loading.md Outdated Show resolved Hide resolved
docs/distributed_data_loading.md Outdated Show resolved Hide resolved
@8bitmp3 8bitmp3 force-pushed the add-distributed-data-loading-doc branch from ee5a762 to 97b6d8e Compare May 16, 2024 22:02
@8bitmp3 8bitmp3 force-pushed the add-distributed-data-loading-doc branch from 97b6d8e to 15a3deb Compare May 16, 2024 23:13
Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels May 17, 2024
@copybara-service copybara-service bot merged commit 8493fc9 into google:main May 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull ready Ready for copybara import and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants