[WIP] Add custom call primitive interface #21402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not yet ready for review. This is a sketch of an interface to abstract away some of the boiler plate required when defining primitives that get lowered to custom calls. There are a few design decisions to consider more carefully, and my goal is to balance supporting a wide range of use cases, without over-committing to a huge public API.
|
Closing in favor of #21484. I'll flesh out the primitive API in a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not yet ready for review.
This is a sketch of an interface to abstract away some of the boiler plate required when defining primitives that get lowered to custom calls. There are a few design decisions to consider more carefully, and my goal is to balance supporting a wide range of use cases, without over-committing to a huge public API.
I note that much of this implementation comes from @superbobry.