Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show cache key when logging compilation cache hits/misses #22556

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Show cache key when logging compilation cache hits/misses #22556

wants to merge 1 commit into from
+13 −13

Conversation

cool-RR
Copy link
Contributor

@cool-RR cool-RR commented Jul 22, 2024

Fixes #22548

@cool-RR
Copy link
Contributor Author

cool-RR commented Jul 22, 2024

Example log lines (not in chronological order):

2024-07-22 11:56:03,008 - DEBUG - Writing jit_matrix_multiply to persistent compilation cache with key 'jit_matrix_multiply-fa478e4ead6882a4c14cc1366d30f8efc783165c9cb16536e025357428373990'
2024-07-22 12:24:05,601 - DEBUG - PERSISTENT COMPILATION CACHE MISS for 'jit_convert_element_type' with key 'jit_convert_element_type-92121ef34fa61ce74b4dad69c9ff3d93d790dbdf2ac0c7664ab8933c8cb46c27'
2024-07-22 12:24:05,834 - DEBUG - PERSISTENT COMPILATION CACHE MISS for 'jit_matrix_multiply' with key 'jit_matrix_multiply-fa478e4ead6882a4c14cc1366d30f8efc783165c9cb16536e025357428373990'
2024-07-22 12:23:09,163 - DEBUG - Persistent compilation cache hit for 'jit_matrix_multiply' with key 'jit_matrix_multiply-fa478e4ead6882a4c14cc1366d30f8efc783165c9cb16536e025357428373990'

@cool-RR
Copy link
Contributor Author

cool-RR commented Jul 22, 2024

@ayaka14732 Could you enable the tests to run here please?

@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels Jul 22, 2024
@cool-RR
Copy link
Contributor Author

cool-RR commented Jul 22, 2024

I believe the CI failure is not related to my changes, as I'm seeing similar failures in other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashk2810 yashk2810 yashk2810 approved these changes

Assignees
No one assigned
Labels
pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When logging cache hit/miss, include cache_key
3 participants
@cool-RR @yashk2810 @kokoro-team