Support mask of broadcast, consts (arange, zeros, ...) #3472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliuskunze
force-pushed
the
mask-const
branch
6 times, most recently
from
04a1b20
to
8945e77
Compare
juliuskunze
force-pushed
the
mask-const
branch
8 times, most recently
from
fe91296
to
6cfa7ed
Compare
juliuskunze
force-pushed
the
mask-const
branch
from
6cfa7ed
to
ee312e3
Compare
juliuskunze
force-pushed
the
mask-const
branch
from
ee312e3
to
90753d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
maskof broadcast (fixing #2769) and constant operations, as well asmask(squeeze)and preparations formask(where).It introduces four new lax primitives (
iota_p,eye_p,delta_p,tri_p), all without inputs (= constants). Together withbroadcast_in_dim_p, each of these requires a target shape (or size) parameter. This shape can be polymorphic during masking. In that case, abstract evaluation of these primitives cannot return aConcreteArray. To solve this, theirabstract_evalfunction is modified to return aShapedArraywith polymorphic shape.maskandshapechecknow require omnistaging, which is default since #4038. @mattjjOmnistaging broke
mask(jit)and thereforemask(where)andmask(pad), see TODOs in tests. Do you already have a plan to fix this?