Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jax2tf] First draft of testing the QR conversion. #3775

Merged
merged 6 commits into from
Jul 21, 2020
Merged

[jax2tf] First draft of testing the QR conversion. #3775

merged 6 commits into from
Jul 21, 2020

Commits on Jul 21, 2020

  1. [jax2tf] First draft of testing the QR conversion. 

    QR decomposition is off by over 1e-6 in some instances, requiring custom
atol and rtol values in testing code. There is an odd problem in which
experimental compilation fails for complex types, although they are in
principle supported.
    @bchetioui
    bchetioui committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    24be819 View commit details
    Browse the repository at this point in the history

  2. Addressed George's comment regarding testing types.

    @bchetioui
    bchetioui committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    3e6023b View commit details
    Browse the repository at this point in the history

  3. Fix tests with regards to George's latest changes.

    @bchetioui
    bchetioui committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    67509c3 View commit details
    Browse the repository at this point in the history

  4. Referenced hawkinsp's comments in the code.

    @bchetioui
    bchetioui committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    4c3fac6 View commit details
    Browse the repository at this point in the history

  5. Fixed thrown error for GPU.

    @bchetioui
    bchetioui committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    48ad8f0 View commit details
    Browse the repository at this point in the history

  6. Reordered tests for clarity.

    @bchetioui
    bchetioui committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    0e788f4 View commit details
    Browse the repository at this point in the history