Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pareto logpdf and sampler #548

Merged
merged 2 commits into from Mar 31, 2019
Merged

Implement pareto logpdf and sampler #548

merged 2 commits into from Mar 31, 2019

Conversation

fehiepsi
Copy link
Member

This PR adds pareto distribution to scipy.stats and random modules.

The design choice for random sampler follows a suggestion in #269 to make the API consistence: jax.random.sampler(key, distribution parameters, shape, dtype).

The parameter name b follows scipy's implementation.

@mattjj mattjj self-requested a review March 31, 2019 13:15
Copy link
Member

@mattjj mattjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@mattjj mattjj merged commit 5866ad3 into google:master Mar 31, 2019
@mattjj
Copy link
Member

mattjj commented Mar 31, 2019

You're really building out our probability stuff quite a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants