add an assert primitive #8773
Merged
add an assert primitive #8773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assert primitive has an effectful API and so it can't be staged out; it's only a trace-time primitive. It can be discharged to the functional form. We might want to have separate transforms for discharging errors and for adding error checks. But right now they're just bundled together in the checkify transform.
LenaMartens
reviewed
Dec 2, 2021
| @@ -212,6 +214,24 @@ def check_errors_traceable(msgs, err, code, *args): | |||
| yield outs | |||
|
|
|||
|
|
|||
| ## assert primitive | |||
|
|
|||
| def assert_(pred: Bool, msg: str) -> None: | |||
There was a problem hiding this comment.
nit: could probably use a nicer public symbol name, but we can think of that later? I guess you're not supposed to overwrite keywords, and we can't provide a checkify.assert?
There was a problem hiding this comment.
I think we can't overwrite assert actually; it's a syntax error. (I tried, of course!)
You're right that this name is bad. But what's a good one? jassert? assert2? asssert? jax_assert? buttert? (Brainstormed those with @skye...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assert primitive has an effectful API and so it can't be staged out; it's only a trace-time primitive. It can be discharged to the functional form.
We might want to have separate transforms for discharging errors and for adding error checks. But right now they're just bundled together in the checkify transform.