-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre_update for OptaxSolver run function? #27
Comments
Indeed, Another option would be to apply So the question is: do we make Any opinion on this would be welcome. |
I may be misinterpreting the role of Happy to chat more about it! |
Moving the call to |
I'm doing some changes in the base classes, I will tackle this issue too. |
Done in #29, opinions welcome! |
Awesome! Thanks for solving it :) |
Hi,
Defining a pre_update function works well in OptaxSolver when using the run_iterator function (like in the MNIST example). However, it does not work with the run function. I checked the implementation and indeed there is no call to the pre_update inside 'run' but there is one inside 'run_iterator'. Is this a small bug or is this by design?
Thanks!
The text was updated successfully, but these errors were encountered: