Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with freezed package #960

Closed
wants to merge 2 commits into from

Conversation

mkranus
Copy link

@mkranus mkranus commented Aug 6, 2021

Freezed package requires the JsonKey annotation to be inserted into the constructor, which is then copied to the generated classes. But currently this use generates a warning, and this PR adds an additional TargetKind so the warning is no longer generated.

@google-cla
Copy link

google-cla bot commented Aug 6, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@mkranus
Copy link
Author

mkranus commented Aug 6, 2021

@googlebot I signed it!

@vi-k
Copy link

vi-k commented Sep 9, 2021

@JsonSerializable
factory ...

-> The annotation 'JsonSerializable' can only be used on classes.

No TargetKind for factory.

@vi-k
Copy link

vi-k commented Sep 9, 2021

@princeteck
Copy link

Any update on this one @mkranus

@kevmoo kevmoo closed this Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants