Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite manifestJson to execute "stacklessly" inside evaluate() #1142

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Rewrite manifestJson to execute "stacklessly" inside evaluate() #1142

wants to merge 9 commits into from

Commits on Mar 9, 2024

  1. Rewrite manifestJson to execute "stacklessly" inside evaluate() 

    This gets rid of the mutual recursion between manifestJson() and
evaluate(), turning the manifestJson processing into a part of the
interpreter's main loop. It should remove one avenue for native
stack overflows during execution.

The Interpreter needed to be able to convert things to JSON anyway,
as this is the behaviour of string coercion (for string concatenation),
and also the behaviour when using the 'error' operator/statement.
    @johnbartholomew
    johnbartholomew committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    b401394 View commit details
    Browse the repository at this point in the history

  2. fix incorrect stack manipulation in FRAME_TO_JSON for objects

    @johnbartholomew
    johnbartholomew committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    b4ee10b View commit details
    Browse the repository at this point in the history

  3. create a FRAME_CALL for nested objects being manifested (to apply sta… 

    …ck limits)
    @johnbartholomew
    johnbartholomew committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    e4f534b View commit details
    Browse the repository at this point in the history

  4. fix a couple of crash bugs with stackless JSON conversion

    @johnbartholomew
    johnbartholomew committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    cbec079 View commit details
    Browse the repository at this point in the history

  5. change the stack handling in FRAME_OBJECT_TO_JSON to get better stack… 

    … traces
    @johnbartholomew
    johnbartholomew committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    2f47ccc View commit details
    Browse the repository at this point in the history

  6. adjust location tracking when manifesting arrays to JSON

    @johnbartholomew
    johnbartholomew committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    39dfb41 View commit details
    Browse the repository at this point in the history

  7. fix crash bug in handling of LocationRange in array to json

    @johnbartholomew
    johnbartholomew committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    5ce04d3 View commit details
    Browse the repository at this point in the history

  8. try to match previous error traces fairly closely

    @johnbartholomew
    johnbartholomew committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    c16d4a3 View commit details
    Browse the repository at this point in the history

  9. refresh error trace goldens

    @johnbartholomew
    johnbartholomew committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    becdd87 View commit details
    Browse the repository at this point in the history