Drop namespace indents. #138
Conversation
This change drops the indent within namespaces. This allows us to save on horizontal whitespace and makes the code a bit easier to follow.
|
have we discussed standardizing on a .clang-format before? |
|
I don't think we have, but I also think it is a good idea to standardize on an established style guide and |
|
Nope, the Google C++ style guide is terrible. However I am definitely in favor of codifying the existing style and fixing any inconsistencies within. |
|
Why do you say that it is terrible? Another option is the LLVM style guide, which is in fact quite similar. |
|
|
||
| /** The captured self variable, or nullptr if there was none. \see CallFrame. */ | ||
| HeapObject *self; | ||
| /** Used in error tracebacks. */ |
There was a problem hiding this comment.
Looks like Github diffing is broken here?
There was a problem hiding this comment.
Yes, looks that way. This patch is purely whitespace changes only aside from the additions of the // namespace comments to the closing braces for the namespaces.
|
LGTM |
|
A good rant on the style guide here: https://www.linkedin.com/pulse/20140503193653-3046051-why-google-style-guide-for-c-is-a-deal-breaker I cut my teeth on Ogre graphics engine and Bullet physics engine, so the style I use is similar to theirs. It's also similar to the code I wrote at IBM for the X10 project. |
|
Yes, I have seen the rant, and I do not 100% agree with it. For example, it mentions that disallowing multiple inheritance is 100% a deal breaker, but I am not convinced that multiple inheritance is a "strength" in practice except for multiple interface inheritance. In any case, let's move this discussion to a separate bug. I've opened #139 to discuss this. |
* Feature-complete commandline interface * Make errors match cpp implementation
As discussed offline, this change drops the indent within namespaces. This allows us to save
on horizontal whitespace and makes the code a bit easier to follow.