fix bazel build #189
Merged
fix bazel build #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 20, 2016 16:17
|
@davidzchen This looks OK to me? What do you think? |
| jsonnet = "//:jsonnet", | ||
| std = "//:std", | ||
| jsonnet = "//cmd:jsonnet", | ||
| std = "//stdlib", |
There was a problem hiding this comment.
Come to think of it, I think we can remove the std attribute since the stdlib is baked into the jsonnet binary. @sparkprime is this correct?
There was a problem hiding this comment.
You may be right that it's unnecessary, but the jsonnet_to_json_test rule defined in the bazel repo has a default value for std, which is simply wrong for these targets.
There was a problem hiding this comment.
I think David's right but we can fix it some other time
There was a problem hiding this comment.
Agreed. I will remove the std attribute from the Bazel Jsonnet rules in a separate change.
|
Just have a few comments, otherwise LGTM. |
|
Comments addressed. PTAL. |
|
LGTM thanks |
This was referenced Nov 20, 2023
sbarzowski
pushed a commit
to sbarzowski/jsonnet
that referenced
this pull request
Jun 10, 2024
* Introduce a Parens AST
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #188