Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give Stack a virtual, public destructor, and add explicit breaks in a sw... #22

Closed
wants to merge 4 commits into from

Conversation

teeler
Copy link

@teeler teeler commented Nov 12, 2014

Explicit breaks during parsing, some random whitespace cleanups, and a virtual public destructor for Stack.

@teeler
Copy link
Author

teeler commented Nov 12, 2014

Oh i did break it..I thought this was already failing, looking.

@sparkprime
Copy link
Member

It looks like this is still failing, on gcc because of parser.cpp:621:18: error: expected identifier before ‘[’ token

and on clang because of

parser.cpp:621:19: error: clang::fallthrough attribute is only allowed on empty
statements
[[clang::fallthrough]]
^
parser.cpp:621:39: note: did you forget ';'?
[[clang::fallthrough]]

@teeler
Copy link
Author

teeler commented Nov 17, 2014

Closing this for now until I can find a better way.

@teeler teeler closed this Nov 17, 2014
@sparkprime
Copy link
Member

This is all now in trunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants