Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument to -m flag to specify the output directory for multi file output #68

Merged
merged 1 commit into from
Sep 15, 2015

Conversation

davidzchen
Copy link
Contributor

Fixes #66

@sparkprime
Copy link
Member

Is it possible to re-use -o for this?

@sparkprime
Copy link
Member

Actually I guess the list of files output should go to -o

@davidzchen
Copy link
Contributor Author

I am not sure whether using -o for this is better. In general, using -o when outputting a single file allows one to rename the output file to something other than the default. However, for multiple file output, the basenames of the files cannot be changed, and the only thing that can be easily changed is which directory the files are written to. I know that adding yet another flag is not ideal, but I think simply setting a directory for multiple file output is easier to do than listing all the output files on -o.

Another option would be to have -m take the output directory an optional argument. What do you think?

By the way, I am not sure what is causing the CI failures. I am unable to reproduce locally using make test.

@sparkprime
Copy link
Member

I am OK with changing -m
On Sep 12, 2015 1:16 PM, "David Z. Chen" notifications@github.com wrote:

I am not sure whether using -o for this is better. In general, using -o
when outputting a single file allows one to rename the output file to
something other than the default. However, for multiple file output, the
basenames of the files cannot be changed, and the only thing that can be
easily changed is which directory the files are written to. I know that
adding yet another flag is not ideal, but I think simply setting a
directory for multiple file output is easier to do than listing all the
output files on -o.

Another option would be to have -m take the output directory an optional
argument. What do you think?

By the way, I am not sure what is causing the CI failures. I am unable to
reproduce locally using make test.


Reply to this email directly or view it on GitHub
#68 (comment).

@davidzchen
Copy link
Contributor Author

Done.

@davidzchen davidzchen changed the title Add flag to specify the output directory for multi file output Add argument to -m flag to specify the output directory for multi file output Sep 14, 2015
@davidzchen
Copy link
Contributor Author

Resolved merge conflicts.

sparkprime added a commit that referenced this pull request Sep 15, 2015
Add argument to -m flag to specify the output directory for multi file output
@sparkprime sparkprime merged commit 5513bf5 into google:master Sep 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants