Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing error when variables in dependencies include '=' #138

Open
danw opened this issue Jul 16, 2018 · 0 comments
Open

Parsing error when variables in dependencies include '=' #138

danw opened this issue Jul 16, 2018 · 0 comments

Comments

@danw
Copy link
Collaborator

danw commented Jul 16, 2018 

installed := my_installed=file
built := my_built=file

$(installed): $(built)
        cp $< $@

This appears to work in make 3.81 & 4.1, but causes a parsing error in kati:

Makefile:5: *** commands commence before first target.

I believe that it's parsing the '=' sign out of $(built) and setting a target-specific variable instead of using it as a dependency.
hubot pushed a commit to aosp-mirror/platform_build that referenced this issue Jul 17, 2018
@danw
Remove '=' from the valid module/stem names
f012af1 
Kati produces errors when a variable containing '=' is used as a
dependency:

google/kati#138

So provide a better error message instead.

Test: Add a module with an '=', see new error
Change-Id: I09d570a8d19abb067621af9983a9d568b643dfb0
mehulagg pushed a commit to mehulagg/superproject that referenced this issue Dec 21, 2019
Update git submodules
8add7ae 
* Update build/make from branch 'master'
  to 45819baa42ee1af7570c1a49e0c67f6f1336bd37
  - Merge "Remove '=' from the valid module/stem names"
  - Remove '=' from the valid module/stem names
    
    Kati produces errors when a variable containing '=' is used as a
    dependency:
    
    google/kati#138
    
    So provide a better error message instead.
    
    Test: Add a module with an '=', see new error
    Change-Id: I09d570a8d19abb067621af9983a9d568b643dfb0
mehulagg pushed a commit to mehulagg/superproject that referenced this issue Dec 21, 2019
Update git submodules
00ae79b 
* Update build/make from branch 'master'
  to 45819baa42ee1af7570c1a49e0c67f6f1336bd37
  - Merge "Remove '=' from the valid module/stem names"
  - Remove '=' from the valid module/stem names
    
    Kati produces errors when a variable containing '=' is used as a
    dependency:
    
    google/kati#138
    
    So provide a better error message instead.
    
    Test: Add a module with an '=', see new error
    Change-Id: I09d570a8d19abb067621af9983a9d568b643dfb0
mehulagg pushed a commit to mehulagg/superproject that referenced this issue Dec 21, 2019
Update git submodules
e04b976 
* Update build/make from branch 'master'
  to 45819baa42ee1af7570c1a49e0c67f6f1336bd37
  - Merge "Remove '=' from the valid module/stem names"
  - Remove '=' from the valid module/stem names
    
    Kati produces errors when a variable containing '=' is used as a
    dependency:
    
    google/kati#138
    
    So provide a better error message instead.
    
    Test: Add a module with an '=', see new error
    Change-Id: I09d570a8d19abb067621af9983a9d568b643dfb0
mehulagg pushed a commit to mehulagg/superproject that referenced this issue Dec 21, 2019
Update git submodules
bcc4a0b 
* Update build/make from branch 'master'
  to 45819baa42ee1af7570c1a49e0c67f6f1336bd37
  - Merge "Remove '=' from the valid module/stem names"
  - Remove '=' from the valid module/stem names
    
    Kati produces errors when a variable containing '=' is used as a
    dependency:
    
    google/kati#138
    
    So provide a better error message instead.
    
    Test: Add a module with an '=', see new error
    Change-Id: I09d570a8d19abb067621af9983a9d568b643dfb0
mehulagg pushed a commit to mehulagg/superproject that referenced this issue Dec 21, 2019
Update git submodules
7a498c6 
* Update build/make from branch 'master'
  to 45819baa42ee1af7570c1a49e0c67f6f1336bd37
  - Merge "Remove '=' from the valid module/stem names"
  - Remove '=' from the valid module/stem names
    
    Kati produces errors when a variable containing '=' is used as a
    dependency:
    
    google/kati#138
    
    So provide a better error message instead.
    
    Test: Add a module with an '=', see new error
    Change-Id: I09d570a8d19abb067621af9983a9d568b643dfb0
mehulagg pushed a commit to mehulagg/superproject that referenced this issue Dec 21, 2019
Update git submodules
5c06e7d 
* Update build/make from branch 'master'
  to 45819baa42ee1af7570c1a49e0c67f6f1336bd37
  - Merge "Remove '=' from the valid module/stem names"
  - Remove '=' from the valid module/stem names
    
    Kati produces errors when a variable containing '=' is used as a
    dependency:
    
    google/kati#138
    
    So provide a better error message instead.
    
    Test: Add a module with an '=', see new error
    Change-Id: I09d570a8d19abb067621af9983a9d568b643dfb0
mehulagg pushed a commit to mehulagg/superproject that referenced this issue Dec 21, 2019
Update git submodules
92bd3dc 
* Update build from branch 'master'
  to 45819baa42ee1af7570c1a49e0c67f6f1336bd37
  - Merge "Remove '=' from the valid module/stem names"
  - Remove '=' from the valid module/stem names
    
    Kati produces errors when a variable containing '=' is used as a
    dependency:
    
    google/kati#138
    
    So provide a better error message instead.
    
    Test: Add a module with an '=', see new error
    Change-Id: I09d570a8d19abb067621af9983a9d568b643dfb0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danw