Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ifdef is still buggy #33

Closed
danw opened this issue Oct 27, 2015 · 1 comment
Closed

ifdef is still buggy #33

danw opened this issue Oct 27, 2015 · 1 comment

Comments

@danw
Copy link
Collaborator

danw commented Oct 27, 2015

ifdef is still buggy when there is an embedded space in the evaluated variable name. This snippet works in make, but not with kati:

A := a # comment

ifdef $(A)
$(error FAIL)
else
$(info PASS)
endif

a := b
ifdef $(A)
$(info PASS)
else
$(error FAIL)
endif

I don't think we're hitting this anywhere, but I noticed it when looking at the latest change.

@shinh
Copy link
Contributor

shinh commented Oct 27, 2015

Good catch! d236eb0 should have fixed this issue.

I forgot "git add" so I've added testcases in a separate commit: 760f959

@shinh shinh closed this as completed Nov 17, 2015
zchee pushed a commit to zchee/kati that referenced this issue Nov 29, 2016
zchee pushed a commit to zchee/kati that referenced this issue Nov 29, 2016
zchee pushed a commit to zchee/kati that referenced this issue Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants