Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-cp src dst, generate command "cp src dst ;", is this right? #47

Closed
wenchiching opened this issue Mar 11, 2016 · 1 comment
Closed

-cp src dst, generate command "cp src dst ;", is this right? #47

wenchiching opened this issue Mar 11, 2016 · 1 comment

Comments

@wenchiching
Copy link

If write a - at beginning of a command line
ckati will generate a command and write a ; at the end of a command line
should ckati write a || (true) at the end of a command line?

take build/core/Makefile for example, if command (rsync -a --exclude=etc --exclude=sdcard out/target/product/xxxxx/root out/target/product/xxxxx/recovery) fail, then build system will continue (rm -f out/target/product/xxxxx/recovery/root/init*.rc) and result in a wrong recovery image

(mkdir -p out/target/product/xxxxx/recovery) &&
(mkdir -p out/target/product/xxxxx/recovery/root/etc out/target/product/xxxxx/recovery/root/sdcard out/target/product/xxxxx/recovery/root/tmp) && 
(echo Copying baseline ramdisk...) && 
(rsync -a --exclude=etc --exclude=sdcard out/target/product/xxxxx/root out/target/product/xxxxx/recovery) &&
(echo Modifying ramdisk contents...) ;
(rm -f out/target/product/xxxxx/recovery/root/init*.rc)
@wenchiching wenchiching changed the title -cp src dst, generate ninja "cp src dst ;", is this right? -cp src dst, generate command "cp src dst ;", is this right? Mar 11, 2016
@shinh shinh closed this as completed in 044a51d Mar 14, 2016
@shinh
Copy link
Contributor

shinh commented Mar 14, 2016

Probably fixed, thanks!

zchee pushed a commit to zchee/kati that referenced this issue Nov 29, 2016
zchee pushed a commit to zchee/kati that referenced this issue Nov 29, 2016
zchee pushed a commit to zchee/kati that referenced this issue Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants