Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad error message for something that's questionably valid #83

Closed
danw opened this issue Jun 30, 2016 · 1 comment
Closed

Bad error message for something that's questionably valid #83

danw opened this issue Jun 30, 2016 · 1 comment

Comments

@danw
Copy link
Collaborator

danw commented Jun 30, 2016

This isn't what people want to do anyway, but the error message looks like a kati problem, when it's really a Makefile problem (and maybe a kati problem if what is breaking is technically valid):

Makefile:

define var
VAR:=1
endef

$(call var)

$(info SUCCESS)

make output:

SUCCESS
make: *** No rule to make target `=1', needed by `VAR'.  Stop.

ckati output:

parser.cc:584: sep != 0
@shinh shinh closed this as completed in c4f7662 Jun 30, 2016
@shinh
Copy link
Contributor

shinh commented Jun 30, 2016

Here's another testcase for the record:

test: =foo

zchee pushed a commit to zchee/kati that referenced this issue Nov 29, 2016
@shinh
[C++] Allow targets which start with `='.
f9e322b 
but with a kati-specific warning message. This fixes google#83.
zchee pushed a commit to zchee/kati that referenced this issue Nov 29, 2016
@shinh
[C++] Allow targets which start with `='.
736fea4 
but with a kati-specific warning message. This fixes google#83.
zchee pushed a commit to zchee/kati that referenced this issue Nov 29, 2016
@shinh
[C++] Allow targets which start with `='.
4054d6b 
but with a kati-specific warning message. This fixes google#83.
danw added a commit to danw/kati that referenced this issue Jun 12, 2020
@danw
Error out on empty variable names
bd385b7 
In google#83 we followed Make's example and accepted empty target-specific
variable names, but now, with Make 4.1, it's an error.

Test: run test suite on ubuntu 18.04 which has Make 4.1
Change-Id: I55211ca1130ce855e9242b6e03401a55b69d2a73
danw added a commit to danw/kati that referenced this issue Jun 12, 2020
@danw
Error out on empty variable names
1c65467 
In google#83 we followed Make's example and accepted empty target-specific
variable names, but now, with Make 4.1, it's an error.

Test: run test suite on ubuntu 18.04 which has Make 4.1
Change-Id: I55211ca1130ce855e9242b6e03401a55b69d2a73
danw added a commit to danw/kati that referenced this issue Jun 12, 2020
@danw
Error out on empty variable names
648af95 
In google#83 we followed Make's example and accepted empty target-specific
variable names, but now, with Make 4.1, it's an error.

Test: run test suite on ubuntu 18.04 which has Make 4.1
Change-Id: I55211ca1130ce855e9242b6e03401a55b69d2a73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shinh @danw