Have pre-commit bootstrap go so that GitHub actions don't need to #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffFaer
force-pushed
the
jfaer/go-bootstrap
branch
7 times, most recently
from
eaee4dc
to
8c89798
Compare
KatrinaHoffert
previously approved these changes
Feb 6, 2024
JeffFaer
force-pushed
the
jfaer/go-bootstrap
branch
from
8c89798
to
8db5d91
Compare
allow pre-commit to bootstrap the go version for us.
JeffFaer
force-pushed
the
jfaer/go-bootstrap
branch
from
8db5d91
to
2c68bb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like GitHub actions only use go 1.20 by default, so anyone using keep-sorted via the GitHub action pre-commit would need to separately install go 1.21. It looks like pre-commit can do that for us automatically.
See #18 (comment) for more details
Tested in a child PR #22