This repository has been archived by the owner on Jul 16, 2021. It is now read-only.
Expose single shot CheckForNewDomains function
#1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some server frameworks support periodic callbacks directly.
gdbelvin
requested review from
phad and
daviddrysdale
and removed request for
phad
Codecov Report
@@ Coverage Diff @@
## master #1020 +/- ##
=========================================
- Coverage 64.89% 64.79% -0.1%
=========================================
Files 39 39
Lines 2692 2696 +4
=========================================
Hits 1747 1747
- Misses 637 641 +4
Partials 308 308
Continue to review full report at Codecov.
|
jtoohill
approved these changes
Jul 16, 2018
gdbelvin
added a commit
to gdbelvin/keytransparency
that referenced
this pull request
Jul 18, 2018
* master: Cleanup domains after integration test (google#1019) Expose single shot `CheckForNewDomains` function (google#1020) Restrict integration.Env to only grpc clients (google#1018)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some server frameworks support periodic callbacks directly.