Skip to content
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.

Set local ID for messages in memory impl #1410

Merged
merged 2 commits into from Dec 20, 2019
Merged

Set local ID for messages in memory impl #1410

merged 2 commits into from Dec 20, 2019

Conversation

pav-kv
Copy link
Contributor

@pav-kv pav-kv commented Dec 17, 2019

No description provided.

@pav-kv pav-kv requested a review from gdbelvin December 17, 2019 14:08
@pav-kv pav-kv requested a review from a team as a code owner December 17, 2019 14:08
@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #1410 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1410      +/-   ##
=========================================
+ Coverage   66.35%   66.5%   +0.15%     
=========================================
  Files          53      53              
  Lines        3980    3986       +6     
=========================================
+ Hits         2641    2651      +10     
+ Misses        951     948       -3     
+ Partials      388     387       -1
Impacted Files Coverage Δ
impl/memory/mutation_logs.go 81.81% <100%> (+2.22%) ⬆️
core/integration/client_tests.go 85.24% <0%> (ø) ⬆️
core/sequencer/server.go 75.24% <0%> (+0.32%) ⬆️
core/sequencer/trillian_client.go 62.85% <0%> (+1.42%) ⬆️
impl/sql/directory/storage.go 69.17% <0%> (+1.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 157c75f...e21fcf5. Read the comment docs.

@pav-kv
Copy link
Contributor Author

pav-kv commented Dec 17, 2019

I wonder if we should have some tests exercising uniqueness of (ID, LocalID).

Copy link
Contributor

@gdbelvin gdbelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test to core/integration/storagetest that verifies the existence of these new fields

@pav-kv
Copy link
Contributor Author

pav-kv commented Dec 20, 2019

Added some test coverage.

@pav-kv pav-kv merged commit 36b088b into google:master Dec 20, 2019
@pav-kv pav-kv deleted the local_id branch December 20, 2019 17:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants