Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set local ID for messages in memory impl #1410

Merged
merged 2 commits into from Dec 20, 2019

Conversation

@pavelkalinnikov
Copy link
Contributor

pavelkalinnikov commented Dec 17, 2019

No description provided.

@pavelkalinnikov pavelkalinnikov requested a review from gdbelvin Dec 17, 2019
@pavelkalinnikov pavelkalinnikov requested a review from google/keytransparency as a code owner Dec 17, 2019
@googlebot googlebot added the cla: yes label Dec 17, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #1410 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1410      +/-   ##
=========================================
+ Coverage   66.35%   66.5%   +0.15%     
=========================================
  Files          53      53              
  Lines        3980    3986       +6     
=========================================
+ Hits         2641    2651      +10     
+ Misses        951     948       -3     
+ Partials      388     387       -1
Impacted Files Coverage Δ
impl/memory/mutation_logs.go 81.81% <100%> (+2.22%) ⬆️
core/integration/client_tests.go 85.24% <0%> (ø) ⬆️
core/sequencer/server.go 75.24% <0%> (+0.32%) ⬆️
core/sequencer/trillian_client.go 62.85% <0%> (+1.42%) ⬆️
impl/sql/directory/storage.go 69.17% <0%> (+1.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 157c75f...e21fcf5. Read the comment docs.

@pavelkalinnikov

This comment has been minimized.

Copy link
Contributor Author

pavelkalinnikov commented Dec 17, 2019

I wonder if we should have some tests exercising uniqueness of (ID, LocalID).

Copy link
Collaborator

gdbelvin left a comment

Please add a test to core/integration/storagetest that verifies the existence of these new fields

@pavelkalinnikov pavelkalinnikov force-pushed the pavelkalinnikov:local_id branch from a277395 to 3e603f6 Dec 20, 2019
@pavelkalinnikov pavelkalinnikov force-pushed the pavelkalinnikov:local_id branch from 3e603f6 to 5cca87e Dec 20, 2019
@pavelkalinnikov

This comment has been minimized.

Copy link
Contributor Author

pavelkalinnikov commented Dec 20, 2019

Added some test coverage.

@pavelkalinnikov pavelkalinnikov merged commit 36b088b into google:master Dec 20, 2019
5 checks passed
5 checks passed
GolangCI No issues found!
Details
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
codecov/patch 100% of diff hit (target 66.35%)
Details
codecov/project 66.5% (+0.15%) compared to 157c75f
Details
@pavelkalinnikov pavelkalinnikov deleted the pavelkalinnikov:local_id branch Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.