Skip to content
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.

Split kt-secrets into kt-tls and kt-monitor #1444

Merged
merged 1 commit into from Jan 28, 2020

Conversation

gdbelvin
Copy link
Contributor

@gdbelvin gdbelvin commented Jan 28, 2020

  • Move Monitor key to it's own secret
  • Move the TLS keys to a TLS secret

By moving the TLS certs into a proper kubernets tls secret, it can be read by an ingress object in the future.

@gdbelvin gdbelvin requested a review from a team as a code owner January 28, 2020 16:00
@gdbelvin gdbelvin requested a review from pav-kv January 28, 2020 16:00
@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #1444 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1444      +/-   ##
==========================================
- Coverage   66.49%   66.44%   -0.05%     
==========================================
  Files          54       54              
  Lines        4026     4026              
==========================================
- Hits         2677     2675       -2     
- Misses        958      959       +1     
- Partials      391      392       +1
Impacted Files Coverage Δ
core/sequencer/trillian_client.go 58.57% <0%> (-4.29%) ⬇️
core/sequencer/server.go 72.96% <0%> (-0.66%) ⬇️
impl/sql/directory/storage.go 69.17% <0%> (ø) ⬆️
core/keyserver/revisions.go 64.62% <0%> (+2.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69dad1c...f37d727. Read the comment docs.

- Move Monitor key to it's own secret
- Move the TLS keys to a TLS secret
@gdbelvin gdbelvin merged commit 50329f2 into google:master Jan 28, 2020
@gdbelvin gdbelvin deleted the tls-secret branch January 28, 2020 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants