This repository has been archived by the owner on Jul 16, 2021. It is now read-only.
Add RSA Implementation of Signer and Verifier in core/signatures #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesarghali
force-pushed
the
signatures_rsa
branch
from
b1ca092
to
86a89f9
Compare
|
This is a low priority feature at the moment. Let's hold off on adding older and less efficient crypto primitives until we have a fully working and tested system. |
|
Sounds good. I will keep this PR open until we decide to merge it. However, if we consider RSA to be old and less efficient, should we consider not supporting it in the first place? |
|
I'm happy for this to go in now. |
cesarghali
force-pushed
the
signatures_rsa
branch
from
59ea63c
to
f33c372
Compare
cesarghali
force-pushed
the
signatures_rsa
branch
from
f33c372
to
df7c818
Compare
|
This PR is rebased. PTAL. |
gdbelvin
approved these changes
Feb 15, 2017
|
Thanks for this PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary tests are added.
Partial #479.