Skip to content
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.

Remove Trillian Fakes #928

Merged
merged 5 commits into from Feb 19, 2018
Merged

Remove Trillian Fakes #928

merged 5 commits into from Feb 19, 2018

Conversation

gdbelvin
Copy link
Contributor

Fakes are not-great, and maintaining them as the Trillian API changes is not sustainable.
Out with fakes -- in with mocks! We get fewer dependencies and more precise test assertions too!

Depends on google/trillian#1006

@codecov-io
Copy link

Codecov Report

Merging #928 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #928   +/-   ##
======================================
  Coverage    51.1%   51.1%           
======================================
  Files          34      34           
  Lines        2489    2489           
======================================
  Hits         1272    1272           
  Misses        988     988           
  Partials      229     229
Impacted Files Coverage Δ
core/keyserver/keyserver.go 33.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d1f669...d2d8445. Read the comment docs.

@gdbelvin gdbelvin merged commit d0b1f4a into google:master Feb 19, 2018
@gdbelvin gdbelvin deleted the fix/mocks branch February 19, 2018 12:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants