New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Trillian Fakes #928

Merged
merged 5 commits into from Feb 19, 2018

Conversation

Projects
None yet
3 participants
@gdbelvin
Collaborator

gdbelvin commented Feb 16, 2018

Fakes are not-great, and maintaining them as the Trillian API changes is not sustainable.
Out with fakes -- in with mocks! We get fewer dependencies and more precise test assertions too!

Depends on google/trillian#1006

@gdbelvin gdbelvin requested review from phad and Martin2112 Feb 16, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Feb 19, 2018

Codecov Report

Merging #928 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #928   +/-   ##
======================================
  Coverage    51.1%   51.1%           
======================================
  Files          34      34           
  Lines        2489    2489           
======================================
  Hits         1272    1272           
  Misses        988     988           
  Partials      229     229
Impacted Files Coverage Δ
core/keyserver/keyserver.go 33.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d1f669...d2d8445. Read the comment docs.

@gdbelvin gdbelvin merged commit d0b1f4a into google:master Feb 19, 2018

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gdbelvin gdbelvin deleted the gdbelvin:fix/mocks branch Feb 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment