Remove options string retroactively. Fixes #211. #454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The template package we use does not let us adjust the internal formatting. I was unable to find a way to disable options via the exposed settings. However, we can capture cobra command output...and remove the troubled text. In the future, we should move away from using this library altogether, especially since it no longer exists in kubectl master
mattysweeps
requested review from
poy,
juliaguo and
josephlewis42
and removed request for
poy and
juliaguo
Out of curiosity, why not do this now? |
|
++ on moving away from this package now, even if we lose the functionality I'd prefer it to a regex filter |
|
Closing this in favor of #559 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template package we use does not let us adjust the internal formatting.
I was unable to find a way to disable options via the exposed settings.
However, we can capture cobra command output...and remove the troubled text.
In the future, we should move away from using this library altogether, especially
since it no longer exists in kubectl master