Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

TestSmokeCloudStorageSourceWithDeletion needs more sleep time in WI tests #1568

Closed
grac3gao-zz opened this issue Aug 11, 2020 · 0 comments · Fixed by #1569
Closed

TestSmokeCloudStorageSourceWithDeletion needs more sleep time in WI tests #1568

grac3gao-zz opened this issue Aug 11, 2020 · 0 comments · Fixed by #1569
Assignees
Labels
kind/bug Something isn't working

Comments

@grac3gao-zz
Copy link
Contributor

grac3gao-zz commented Aug 11, 2020

Describe the bug
According to errors from some failed test:
https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/google_knative-gcp/1564/pull-google-knative-gcp-wi-tests/1292842220960878592
https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/google_knative-gcp/1531/pull-google-knative-gcp-wi-tests/1288887263408689153
https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/google_knative-gcp/1514/pull-google-knative-gcp-wi-tests/1287889815001370627
https://prow.knative.dev/view/gcs/knative-prow/logs/ci-google-knative-gcp-continuous/1291574743903768576

TestSmokeCloudStorageSourceWithDeletion needs more sleep time in WI tests, otherwise, the notification, which is supposed to be deleted, is still there.

Note: only TestSmokeCloudStorageSourceWithDeletion needs more sleep time, other deletion tests run well.\

According to PubSub SLO, 99% admin operations (like create/delete) will finish in 60s. We could try 60s for the sleep time

Expected behavior
A clear and concise description of what you expected to happen.

To Reproduce
Steps to reproduce the behavior.

Knative-GCP release version

Additional context
Add any other context about the problem here such as proposed priority

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant