Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Update pubsub to use secrets and fix serving version to v1alpha1. #124

Merged
merged 2 commits into from Aug 1, 2019

Conversation

n3wscott
Copy link
Contributor

@n3wscott n3wscott commented Aug 1, 2019

No description provided.

@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-googlecloudplatform-cloud-run-events-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pubsub/v1alpha1/topic_lifecycle.go 78.3% 75.0% -3.3
pkg/reconciler/topic/controller.go 93.3% 77.3% -16.1
pkg/reconciler/topic/resources/names.go Do not exist 100.0%
pkg/reconciler/topic/resources/publisher.go 71.4% 81.8% 10.4
pkg/reconciler/topic/topic.go 67.3% 53.6% -13.7

@vaikas
Copy link
Contributor

vaikas commented Aug 1, 2019

can we bring up the test coverage for the components on a followup PR...
/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [n3wscott,vaikas-google]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google google deleted a comment from knative-prow-robot Aug 1, 2019
@knative-prow-robot knative-prow-robot merged commit 36b84c6 into google:master Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants