Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Use CloudEventOverrides from Storage and pass down to PullSubscription. #192

Merged
merged 2 commits into from
Aug 20, 2019

Conversation

n3wscott
Copy link
Contributor

fixes: #172

@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/storage/resources/pullsubscription.go Do not exist 87.5%
pkg/reconciler/storage/resources/topic.go Do not exist 80.0%

@n3wscott
Copy link
Contributor Author

/assign @vaikas-google

@vaikas
Copy link
Contributor

vaikas commented Aug 20, 2019

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [n3wscott,vaikas-google]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 9335b3e into google:master Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the cloudEventOverrides should propagate down into the PullSubscription, not added to the customAttributes
4 participants