Configure webhook port in yaml #1980

grantr · 2020-12-05T00:35:45Z

This is how Eventing configures its webhook. Keeps us closer to the Eventing state and adds some flexibility to the port the webhook runs on.

Proposed Changes

Release Note

:gift: The webhook now listens on the port set in the WEBHOOK_PORT environment variable or 8443 if unset.

This is how Eventing configures its webhook. Adds some flexibility to the port the webhook runs on.

eclipselu · 2020-12-07T14:54:43Z

/lgtm
/approve

knative-prow-robot · 2020-12-07T14:54:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eclipselu, grantr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

eclipselu · 2020-12-07T16:25:33Z

/test pull-google-knative-gcp-integration-tests

fix: Configure webhook port in yaml

6bca12f

This is how Eventing configures its webhook. Adds some flexibility to the port the webhook runs on.

knative-prow-robot requested review from AlexandraRoatis and liu-cong December 5, 2020 00:35

knative-prow-robot added the approved label Dec 5, 2020

google-cla bot added the cla: yes (override cla status due to multiple authors bug) label Dec 5, 2020

knative-prow-robot added the size/XS label Dec 5, 2020

knative-prow-robot assigned eclipselu Dec 7, 2020

knative-prow-robot added the lgtm label Dec 7, 2020

knative-prow-robot merged commit c8e9e2c into google:master Dec 7, 2020

grantr deleted the webhook-port branch December 8, 2020 00:26