Allow comma-separated list of platforms #259

jonjohnsonjr · 2020-12-07T22:01:07Z

Fixes #253

Fixes #274

$ ko publish -B --platform=linux/amd64,linux/arm64 ./cmd/ko/
2020/12/07 13:57:20 Using base gcr.io/distroless/static:nonroot for github.com/google/ko/cmd/ko
2020/12/07 13:57:21 Building github.com/google/ko/cmd/ko for linux/amd64
2020/12/07 13:57:25 Building github.com/google/ko/cmd/ko for linux/arm64
2020/12/07 13:57:29 Publishing gcr.io/jonjohnson-test/ko/ko:latest
2020/12/07 13:57:30 existing blob: sha256:72164b581b02b1eb297b403bcc8fc1bfa245cb52e103a3a525a0835a58ff58e2
2020/12/07 13:57:30 existing blob: sha256:e59bd8947ac7af2c8f4403b183326986ab554bbc262739cf5d9d596c7c7a3aca
2020/12/07 13:57:31 pushed blob: sha256:314bd22f324d73c81d23dd94a14e3a4df6a591381e39b9164163208115c23ae4
2020/12/07 13:57:33 pushed blob: sha256:dd714425e64113dddc2cf7a21a1b7f47c20ae29dc2072284b64fe1e7b82a5307
2020/12/07 13:57:33 gcr.io/jonjohnson-test/ko/ko@sha256:cb6a0c6cb99e6c7b1d7dfd598484d0d25b74e15a69837f3d87c08c58ee7f88e2: digest: sha256:cb6a0c6cb99e6c7b1d7dfd598484d0d25b74e15a69837f3d87c08c58ee7f88e2 size: 751
2020/12/07 13:57:34 existing blob: sha256:72164b581b02b1eb297b403bcc8fc1bfa245cb52e103a3a525a0835a58ff58e2
2020/12/07 13:57:34 existing blob: sha256:d34b09c140e4b67f2c6214e24f26a68bc6b17c28d42f0dda89db38ad03488416
2020/12/07 13:57:35 pushed blob: sha256:99af2cd1b289d3a47aba52934e2ac8c4037e92563e8a4d119b5d0e040f5b9ed3
2020/12/07 13:57:37 pushed blob: sha256:052d3194d06e9194d60e7dcdce4c7d8e91df952f34dfddd461ce181732342db2
2020/12/07 13:57:37 gcr.io/jonjohnson-test/ko/ko@sha256:ca19f1aa2adc983e55c1eb7d6af1ed8574991ff6762eccec8ef7b5e5d965d1ce: digest: sha256:ca19f1aa2adc983e55c1eb7d6af1ed8574991ff6762eccec8ef7b5e5d965d1ce size: 751
2020/12/07 13:57:38 gcr.io/jonjohnson-test/ko/ko:latest: digest: sha256:03ed41dd8676e9988fb4958366cf8d38fbb39e576d5b09bb1cc108c937e6d7ff size: 529
2020/12/07 13:57:38 Published gcr.io/jonjohnson-test/ko/ko@sha256:03ed41dd8676e9988fb4958366cf8d38fbb39e576d5b09bb1cc108c937e6d7ff
gcr.io/jonjohnson-test/ko/ko@sha256:03ed41dd8676e9988fb4958366cf8d38fbb39e576d5b09bb1cc108c937e6d7ff

codecov-io · 2020-12-07T22:06:33Z

Codecov Report

Merging #259 (f7ff6cc) into master (5b08b05) will increase coverage by 1.20%.
The diff coverage is 68.75%.

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   37.06%   38.27%   +1.20%     
==========================================
  Files          33       33              
  Lines        1465     1505      +40     
==========================================
+ Hits          543      576      +33     
- Misses        833      838       +5     
- Partials       89       91       +2

Impacted Files	Coverage Δ
pkg/commands/config.go	`16.17% <0.00%> (+0.89%)`	⬆️
pkg/commands/resolver.go	`11.93% <0.00%> (-0.50%)`	⬇️
pkg/build/gobuild.go	`61.24% <88.23%> (+3.01%)`	⬆️
pkg/build/options.go	`85.71% <100.00%> (+2.38%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b08b05...f7ff6cc. Read the comment docs.

imjasonh · 2020-12-08T18:32:58Z

Can you include README.md in this change?

In particular, what happens if I pass ko resolve --platform=A,B and some of the images built in the process support both platforms while some only support one or the other (or neither).

jonjohnsonjr · 2020-12-08T18:34:00Z

Will do -- also want to fix the TODO in there, but wanted to hack something together to play with the UX.

jonjohnsonjr · 2020-12-08T22:16:51Z

PTAL, cc @mattmoor

pkg/build/gobuild_test.go

README.md

mattmoor · 2020-12-14T16:27:22Z

pkg/build/gobuild.go

+		platform:             gbo.platform,
+		parsedPlatform:       parsed,


Feels like we've got a datastructure we're hiding in a couple fields of gobuild. Should we create a little PlatformMatcher that we build from the string, which captures this state and surfaces methods for matching a platform?

Done, kind of. Not sure if we need this anywhere else, so didn't expose it.

Co-authored-by: Matt Moore <mattmoor@vmware.com>

Also respect GOARM as variant if the goarch is arm.

google-cla · 2020-12-21T21:49:07Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2020-12-21T21:54:16Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

mattmoor · 2020-12-21T21:58:33Z

@googlebot I consent!

google-cla · 2020-12-21T21:58:40Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

mattmoor · 2020-12-21T21:58:49Z

@googlebot I consent.

google-cla · 2020-12-21T21:58:55Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

jonjohnsonjr · 2020-12-21T22:00:28Z

@googlebot I consent.

google-cla · 2020-12-21T22:00:34Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

googlebot · 2020-12-21T22:00:49Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2020-12-21T22:03:03Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

jonjohnsonjr · 2020-12-21T23:58:22Z

2020/12/21 21:57:23 error creating builder: error setting up builder options: cannot use --platform with GOOS="linux"

This failed in the way I wanted it to, wdyt @mattmoor

google-cla · 2020-12-22T00:16:11Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

mattmoor

Seems fine to me. --platform is the future :)

mattmoor reviewed Dec 14, 2020

View reviewed changes

pkg/build/gobuild_test.go Outdated Show resolved Hide resolved

mattmoor reviewed Dec 14, 2020

View reviewed changes

README.md Outdated Show resolved Hide resolved

mattmoor reviewed Dec 14, 2020

View reviewed changes

jonjohnsonjr and others added 6 commits December 21, 2020 13:41

Allow comma-separated list of platforms

e5168a4

Parse platform spec once

acdf83f

Update --platform docs in README

a21c7a0

Update pkg/build/gobuild_test.go

eda26fc

Co-authored-by: Matt Moore <mattmoor@vmware.com>

Return err for bad defaulting for --platform

02c68d0

Also respect GOARM as variant if the goarch is arm.

Refactor platform matching

f447fd2

jonjohnsonjr force-pushed the platforms branch from 597a1ed to f447fd2 Compare December 21, 2020 21:49

Update README.md to mention GOARM

8706b09

jonjohnsonjr added the cla: yes label Dec 21, 2020

Fix travis test

7999d02

google-cla bot added cla: no and removed cla: yes labels Dec 22, 2020

jonjohnsonjr added cla: yes and removed cla: no labels Dec 22, 2020

mattmoor approved these changes Dec 22, 2020

View reviewed changes

jonjohnsonjr merged commit 7e32453 into ko-build:master Dec 22, 2020

jonjohnsonjr deleted the platforms branch December 22, 2020 00:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow comma-separated list of platforms #259

Allow comma-separated list of platforms #259

jonjohnsonjr commented Dec 7, 2020 •

edited

codecov-io commented Dec 7, 2020 •

edited

imjasonh commented Dec 8, 2020

jonjohnsonjr commented Dec 8, 2020

jonjohnsonjr commented Dec 8, 2020

mattmoor Dec 14, 2020

jonjohnsonjr Dec 21, 2020

google-cla bot commented Dec 21, 2020

google-cla bot commented Dec 21, 2020

mattmoor commented Dec 21, 2020

google-cla bot commented Dec 21, 2020

mattmoor commented Dec 21, 2020

google-cla bot commented Dec 21, 2020

jonjohnsonjr commented Dec 21, 2020

google-cla bot commented Dec 21, 2020

googlebot commented Dec 21, 2020

google-cla bot commented Dec 21, 2020

jonjohnsonjr commented Dec 21, 2020

google-cla bot commented Dec 22, 2020

mattmoor left a comment

Allow comma-separated list of platforms #259

Allow comma-separated list of platforms #259

Conversation

jonjohnsonjr commented Dec 7, 2020 • edited

codecov-io commented Dec 7, 2020 • edited

Codecov Report

imjasonh commented Dec 8, 2020

jonjohnsonjr commented Dec 8, 2020

jonjohnsonjr commented Dec 8, 2020

mattmoor Dec 14, 2020

Choose a reason for hiding this comment

jonjohnsonjr Dec 21, 2020

Choose a reason for hiding this comment

google-cla bot commented Dec 21, 2020

google-cla bot commented Dec 21, 2020

mattmoor commented Dec 21, 2020

google-cla bot commented Dec 21, 2020

mattmoor commented Dec 21, 2020

google-cla bot commented Dec 21, 2020

jonjohnsonjr commented Dec 21, 2020

google-cla bot commented Dec 21, 2020

googlebot commented Dec 21, 2020

google-cla bot commented Dec 21, 2020

jonjohnsonjr commented Dec 21, 2020

google-cla bot commented Dec 22, 2020

mattmoor left a comment

Choose a reason for hiding this comment

jonjohnsonjr commented Dec 7, 2020 •

edited

codecov-io commented Dec 7, 2020 •

edited