Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cobra's RunE wherever possible #343

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Conversation

imjasonh
Copy link
Member

Notably, this makes ko exit 1 when kubectl isn't installed, instead of logging and otherwise doing nothing.

Less notably, this makes the error from ko run slightly less verbose.

Otherwise no functional changes are expected.

@codecov-commenter
Copy link

Codecov Report

Merging #343 (751f32d) into main (75ab991) will increase coverage by 0.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
+ Coverage   38.24%   38.37%   +0.12%     
==========================================
  Files          33       33              
  Lines        1527     1522       -5     
==========================================
  Hits          584      584              
+ Misses        849      844       -5     
  Partials       94       94              
Impacted Files Coverage Δ
pkg/commands/apply.go 0.00% <0.00%> (ø)
pkg/commands/create.go 0.00% <0.00%> (ø)
pkg/commands/delete.go 0.00% <0.00%> (ø)
pkg/commands/publish.go 0.00% <0.00%> (ø)
pkg/commands/resolve.go 0.00% <0.00%> (ø)
pkg/commands/run.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75ab991...751f32d. Read the comment docs.

@imjasonh imjasonh merged commit 29cd8e0 into ko-build:main Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants